Open
Conversation
kwitaechong
force-pushed
the
normalize_vector1
branch
from
1057c5d to
bc6b3a8
Compare
Collaborator
Author
|
Do we need to checkout when its size norm2= 0 for this and other normalize? |
streeve
reviewed
Sep 29, 2023
Collaborator
streeve
left a comment
streeve
left a comment
There was a problem hiding this comment.
Need to add to the tests. Could handle divide by zero in a separate PR or here
kwitaechong
force-pushed
the
normalize_vector1
branch
from
4db5c44 to
97bacd3
Compare
kwitaechong
force-pushed
the
normalize_vector1
branch
from
97bacd3 to
4f6ab50
Compare
streeve
requested changes
Oct 24, 2023
Collaborator
streeve
left a comment
streeve
left a comment
There was a problem hiding this comment.
Can you add a check in the unit test?
kwitaechong
force-pushed
the
normalize_vector1
branch
from
4f6ab50 to
1a4940a
Compare
streeve
reviewed
Oct 26, 2023
| EXPECT_DOUBLE_EQ( vec1, 1.0 ); | ||
|
|
||
| // Size 1 vector test. | ||
| // FIXME: construction of length 1 vector fails with NVCC. |
Collaborator
There was a problem hiding this comment.
Does this test pass? We commented this out below because of issues with cuda
Collaborator
Author
There was a problem hiding this comment.
Yes, it passed on V100
Collaborator
There was a problem hiding this comment.
Does the commented code below pass?
Collaborator
There was a problem hiding this comment.
Oh maybe it's trying to construct from a scalar that fails
Collaborator
Author
There was a problem hiding this comment.
Yes, commented code also get passed on V100
Collaborator
|
retest this please. |
kwitaechong
force-pushed
the
normalize_vector1
branch
from
eadfa85 to
5b7e844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.